Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.2: sql: internal error with BUCKET_COUNT = NULL #131602

Merged
merged 1 commit into from
Sep 30, 2024
Merged

release-24.2: sql: internal error with BUCKET_COUNT = NULL #131602

merged 1 commit into from
Sep 30, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 30, 2024 •
edited by rafiss
Loading

Backport 1/1 commits from #131212 on behalf of @vidit-bhat.

/cc @cockroachdb/release

Previously, the EvalShardBucketCount function did not properly handle the case where BUCKET_COUNT was set to NULL, causing evaluation errors. This change adds explicit handling for NULL values, ensuring that BUCKET_COUNT cannot be set to NULL and returns an appropriate error message.

Epic: none
Fixes: #130353
Release note: None

Release justification: bug fix

@vidit-bhat
sql: internal error with BUCKET_COUNT = NULL
77c0c53 
Previously, the `EvalShardBucketCount` function did
not properly handle the case where `BUCKET_COUNT` was
set to `NULL`, causing evaluation errors. This change
adds explicit handling for `NULL` values, ensuring that
`BUCKET_COUNT` cannot be set to `NULL` and returns an
appropriate error message.

Also added a check for NULL before sanitizing and evaluating shardBuckets
to avoid invalid operations on NULL values.
returns the error `BUCKET_COUNT cannot be NULL`.

Epic: none
Fixes: #130353
Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-131212 branch from 7836820 to 77c0c53 Compare September 30, 2024 15:12
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 30, 2024 15:12
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 30, 2024
@blathers-crl blathers-crl bot requested a review from spilchen September 30, 2024 15:12
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Sep 30, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 30, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit d9c2cfb into release-24.2 Sep 30, 2024
19 of 20 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.2-131212 branch September 30, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@spilchen spilchen Awaiting requested review from spilchen

Assignees

@vidit-bhat vidit-bhat

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rafiss @vidit-bhat