-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1.5-rc: sql: deflake TestValidationWithProtectedTS #131315
Closed
blathers-crl
wants to merge
1
commit into
release-24.1.5-rc
from
blathers/backport-release-24.1.5-rc-130942
Closed
release-24.1.5-rc: sql: deflake TestValidationWithProtectedTS #131315
blathers-crl
wants to merge
1
commit into
release-24.1.5-rc
from
blathers/backport-release-24.1.5-rc-130942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test does not work if ranges get split, so we disable the split queue. Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-24.1.5-rc-130942
branch
from
September 24, 2024 19:28
99e7f88
to
ce58ec5
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Sep 24, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Sep 24, 2024
fqazi
changed the title
release-24.1.5-rc: release-24.1: sql: deflake TestValidationWithProtectedTS
release-24.1: sql: deflake TestValidationWithProtectedTS
Sep 24, 2024
fqazi
changed the title
release-24.1: sql: deflake TestValidationWithProtectedTS
release-24.1.5-rc: sql: deflake TestValidationWithProtectedTS
Sep 24, 2024
spilchen
approved these changes
Sep 24, 2024
Dedej-Bergin
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #130906 on behalf of @rafiss.
/cc @cockroachdb/release
This test does not work if ranges get split, so we disable the split queue.
fixes #130715
Release note: None
Release justification: test only change