ccl/sqlproxyccl: add proxy.sql.routing_method_count metric #130892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jaylim-crl
requested review from
jeffswenson and
DuskEagle
and removed request for
a team
jaylim-crl
force-pushed
the
jay/240917-add-connection-metrics-to-proxy
branch
2 times, most recently
from
7111ef8 to
bf1c3d4
Compare
jaylim-crl
added
backport-24.1.x
jeffswenson
approved these changes
Sep 17, 2024
pkg/ccl/sqlproxyccl/metrics.go
Outdated
| Name: "proxy.access_control.errors", | ||
| Help: "Numbers of access control list files that are currently having errors", | ||
| Measurement: "Access Control File Errors", | ||
| Unit: metric.Unit_COUNT, | ||
| } | ||
| metaClusterIdentifierReadsTotal = metric.Metadata{ | ||
| Name: "proxy.cluster_identifier.reads_total", |
There was a problem hiding this comment.
nit: what do you think of the name proxy.sql.routing_method? reads_total sounds like a metric that counts how many times something is looked up in the database.
There was a problem hiding this comment.
Done. I updated it to proxy.sql.routing_method_count.
Previously, it was not possible to determine the distribution of users connecting to the proxy via SNI, database, or cluster option (via the options parameter). This commit introduces a `proxy.sql.routing_method_count` metric to record the number of occurrences of each proxy routing method. Only successful parsing will be recorded; if a user provides invalid input, it will not be tracked. This enhancement allows us to monitor and understand which method was used by the proxy to retrieve the cluster identifier. Epic: CC-6926 Release note: None
jaylim-crl
force-pushed
the
jay/240917-add-connection-metrics-to-proxy
branch
from
bf1c3d4 to
56fc243
Compare
jaylim-crl
changed the title
|
Thanks for the reviews! |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was not possible to determine the distribution of users
connecting to the proxy via SNI, database, or cluster option (via the options
parameter). This commit introduces a
proxy.sql.routing_method_countmetric to record the number of occurrences of each proxy routing method. Only
successful parsing will be recorded; if a user provides invalid input, it will
not be tracked. This enhancement allows us to monitor and understand which
method was used by the proxy to retrieve the cluster identifier.
Epic: CC-6926
Release note: None