-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2.12-rc: server, util: fix failing TestServerController #130883
Merged
shubhamdhama
merged 1 commit into
release-23.2.12-rc
from
blathers/backport-release-23.2.12-rc-130850
Sep 19, 2024
Merged
release-23.2.12-rc: server, util: fix failing TestServerController #130883
shubhamdhama
merged 1 commit into
release-23.2.12-rc
from
blathers/backport-release-23.2.12-rc-130850
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TestServerController` test server stops quickly (due to deferred stop) after executing `CREATE TENANT hello` while the creation of the tenant is ongoing in `newTenantServer`. This causes `baseCfg.CidrLookup.Start` in `newTenantServer` to fail with `ErrUnavailable` because `s.runPrelude()` in `stopper.RunAsyncTask` returns true if a server is stopping: https://github.com/cockroachdb/cockroach/blob/3bf34dc3a192d7efeee8aa97e46bf73f817b2b9b/pkg/util/stop/stopper.go#L469-L471. Fixes: #130757 Epic: CRDB-42208 Release note: None
blathers-crl
bot
requested review from
angles-n-daemons
and removed request for
a team
September 17, 2024 15:23
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2.12-rc-130850
branch
from
September 17, 2024 15:23
7b8fd7d
to
b200f20
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Sep 17, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
requested review from
andrewbaptist,
kyle-a-wong and
stevendanna
September 17, 2024 15:23
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Sep 17, 2024
andrewbaptist
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shubhamdhama
deleted the
blathers/backport-release-23.2.12-rc-130850
branch
September 19, 2024 09:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #130850 on behalf of @shubhamdhama.
/cc @cockroachdb/release
The
TestServerController
test server stops quickly (due to deferred stop) after executingCREATE TENANT hello
while the creation of the tenant is ongoing innewTenantServer
. This causesbaseCfg.CidrLookup.Start
innewTenantServer
to fail withErrUnavailable
becauses.runPrelude()
instopper.RunAsyncTask
returns true if a server is stopping:cockroach/pkg/util/stop/stopper.go
Lines 469 to 471 in 3bf34dc
Fixes: #130757
Epic: CRDB-42208
Release note: None
Release justification: fix failing TestServerController.