Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: server/license: Integrate license throttle with SQL #130868

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 17, 2024

Backport 1/1 commits from #130263 on behalf of @spilchen.

/cc @cockroachdb/release


Prior to this, the throttling code had been implemented but wasn’t integrated with SQL. This change completes that integration, applying throttling only to external SQL queries—internal SQL queries are exempt. If throttling is active, an error is returned and propagated to the caller.

For licenses requiring telemetry, the latest telemetry ping time is used in the throttling calculation by implementing the
license.TelemetryStatusReporter interface.

Most throttling functionality remains disabled, enabled only in unit tests or via environment variables. Full throttling will be enabled in CRDB-41758.

Epic: CRDB-39988
Closes: CRDB-39991
Release note: None


Release justification: This work is part of the CockroachDB core deprecation.

Prior to this, the throttling code had been implemented but wasn’t
integrated with SQL. This change completes that integration, applying
throttling only to external SQL queries—internal SQL queries are exempt.
If throttling is active, an error is returned and propagated to the
caller.

For licenses requiring telemetry, the latest telemetry ping time is used
in the throttling calculation by implementing the
license.TelemetryStatusReporter interface.

Most throttling functionality remains disabled, enabled only in unit
tests or via environment variables. Full throttling will be enabled in
CRDB-41758.

Epic: CRDB-39988
Closes: CRDB-39991
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 17, 2024 14:18
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-130263 branch from 0bc8582 to bb7d608 Compare September 17, 2024 14:18
@blathers-crl blathers-crl bot requested review from kyle-a-wong and removed request for a team September 17, 2024 14:18
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 17, 2024
Copy link
Author

blathers-crl bot commented Sep 17, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 17, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@spilchen spilchen requested a review from rafiss September 17, 2024 18:19
@spilchen spilchen merged commit 8ed9162 into release-24.2 Sep 18, 2024
19 of 20 checks passed
@spilchen spilchen deleted the blathers/backport-release-24.2-130263 branch September 18, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants