release-23.2.12-rc: kvserver: compact liveness range periodically #130711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #129827.
/cc @cockroachdb/release
This commit adds a cluster setting (turned off by default) that sets the period at which manual liveness range compactions are done.
This is done in a goroutine rather than in MVCC GC queue because:
This is meant to be a stop gap as this in not needed in 24.3 onwards. Therefore, a simple change like this should achieve the goal.
The MVCC GC queue runs against leaseholder replicas only. This means that we need to send a compaction request to the other liveness replicas.
Fixes: #128968
Epic: None
Release note: None
Release justification: Help reduce point tombstone accumulation on the liveness range