Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drtprod: yaml config support #130646

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

nameisbhaskar
Copy link
Contributor

This implementation of drtprod enables you to define the series of commands in a YAML file and execute the same. This way you can define a sequence of commands for a cluster.

You can find more details in https://cockroachlabs.atlassian.net/l/cp/0nxKZuyP.

With this the expectation is to decommission drtprod script and move all configurations to smaller scripts and yaml.

Fixes: #125381
Epic: None

Copy link

blathers-crl bot commented Sep 13, 2024

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nameisbhaskar nameisbhaskar force-pushed the user/bhaskar/drt-prod branch 5 times, most recently from f71d787 to f69ce91 Compare September 14, 2024 05:16
Copy link

blathers-crl bot commented Sep 14, 2024

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@nameisbhaskar nameisbhaskar force-pushed the user/bhaskar/drt-prod branch 5 times, most recently from c2c91af to 6cf3549 Compare September 15, 2024 04:25
@nameisbhaskar nameisbhaskar marked this pull request as ready for review September 15, 2024 17:59
@nameisbhaskar nameisbhaskar requested review from a team as code owners September 15, 2024 17:59
@nameisbhaskar nameisbhaskar force-pushed the user/bhaskar/drt-prod branch 3 times, most recently from 668478e to 0b7b575 Compare September 16, 2024 16:34
Copy link
Contributor

@sambhav-jain-16 sambhav-jain-16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nameisbhaskar , this tool is going to be really useful.

One minor comment.
Apart from it LGTM !

pkg/cmd/drtprod/cli/handlers.go Outdated Show resolved Hide resolved
@nameisbhaskar
Copy link
Contributor Author

Thanks @sambhav-jain-16 @vidit-bhat for the review!

@nameisbhaskar
Copy link
Contributor Author

bors r=@sambhav-jain-16,@vidit-bhat

1 similar comment
@nameisbhaskar
Copy link
Contributor Author

bors r=@sambhav-jain-16,@vidit-bhat

This implementation of drtprod enables you to define the series
of commands in a YAML file and execute the same. This way you can
define a sequence of commands per cluster.

Fixes: cockroachdb#125381
Epic: None
@craig
Copy link
Contributor

craig bot commented Sep 25, 2024

Canceled.

@nameisbhaskar
Copy link
Contributor Author

bors r=@sambhav-jain-16,@vidit-bhat

@craig craig bot merged commit 59061df into cockroachdb:master Sep 25, 2024
23 checks passed
@nameisbhaskar nameisbhaskar deleted the user/bhaskar/drt-prod branch December 1, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drtprod: implement drt prod in golang rather than shell for better meintenance
4 participants