-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drtprod: yaml config support #130646
drtprod: yaml config support #130646
Conversation
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
f71d787
to
f69ce91
Compare
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
c2c91af
to
6cf3549
Compare
668478e
to
0b7b575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nameisbhaskar , this tool is going to be really useful.
One minor comment.
Apart from it LGTM !
0b7b575
to
85d2341
Compare
Thanks @sambhav-jain-16 @vidit-bhat for the review! |
bors r=@sambhav-jain-16,@vidit-bhat |
1 similar comment
bors r=@sambhav-jain-16,@vidit-bhat |
This implementation of drtprod enables you to define the series of commands in a YAML file and execute the same. This way you can define a sequence of commands per cluster. Fixes: cockroachdb#125381 Epic: None
85d2341
to
bae534f
Compare
Canceled. |
bors r=@sambhav-jain-16,@vidit-bhat |
This implementation of drtprod enables you to define the series of commands in a YAML file and execute the same. This way you can define a sequence of commands for a cluster.
You can find more details in https://cockroachlabs.atlassian.net/l/cp/0nxKZuyP.
With this the expectation is to decommission drtprod script and move all configurations to smaller scripts and yaml.
Fixes: #125381
Epic: None