[wip] gossip: use ptp clock when configured #130496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit we saw "info not fresh" errors related to gossip while running the ptp roachtest introduced in cockroachdb#129123. Since gossip takes walltimes of the local clock and shoves them into HLC timestamps, it's likely that there are places where we might end up comparing these to timestamps sourced from a ptp clock, if the system is configured with one. If these two clocks don't agree, this is problematic.
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit we saw "info not fresh" errors related to gossip
while running the ptp roachtest introduced in #129123. Since gossip
takes walltimes of the local clock and shoves them into HLC timestamps,
it's likely that there are places where we might end up comparing these
to timestamps sourced from a ptp clock, if the system is configured with
one. If these two clocks don't agree, this is problematic.