replica_rac2: rm unused waitingForAdmissionState #130382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pav-kv
commented
Sep 10, 2024
sumeerbhola
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @pav-kv)
pav-kv
force-pushed
the
rm-waiting-for-admission-state
branch
2 times, most recently
from
551b4a8 to
dc62e69
Compare
|
bors r=sumeerbhola |
|
Build failed: |
|
bors cancel |
pav-kv
force-pushed
the
rm-waiting-for-admission-state
branch
from
dc62e69 to
5f0005c
Compare
Also copy the comment explaining why we chose to track individual log indices rather then compressing them into a single "waiting" interval. Epic: none Release note: none
pav-kv
force-pushed
the
rm-waiting-for-admission-state
branch
from
5f0005c to
10e0be2
Compare
|
bors r=sumeerbhola |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also copy the comment explaining why we chose to track individual log indices rather then compressing them into a single "waiting" interval.
Part of #129508