changefeedccl: deflake TestChangefeedWithSimpleDistributionStrategy #130242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskettaneh
requested review from
andyyang890 and
arulajmani
and removed request for
a team
|
This change is |
arulajmani
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks for digging into this and the quick fix 💯
Also, we should add backport labels for all the releases that this test is failing for. That way, when the PR merges, we'll automatically open a backport.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @andyyang890)
This change: cockroachdb#125117 removed giving 1M upfront tokens to new tenants. This seems that have cause some throttling in this test. This commit re-adds the 1M upfront tokens for this test. Fixes: cockroachdb#125170 Epic: None Release note: None
iskettaneh
force-pushed
the
DeflakeChangeFeedSimpleTest
branch
from
4ee8023 to
9bc754d
Compare
|
bors r+ |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #125170: branch-release-24.2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: #125117 removed giving 1M upfront tokens to new tenants. This seems that have cause some throttling in this test. This commit re-adds the 1M upfront tokens for the affected tests.
Fixes: #125170
Epic: None
Release note: None