rpc,tenantcapabilities: allow cross tenant reads in shared service #130183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we added support for cross tenant reads, but these would only function from the system tenant. When running as a shared service tenant, we should also allow reading the spans of other tenants. To address this, this patch updates authorization logic to look at the authorization mode to determine if the cross tenant read check should be enforced, which will allow shared service tenants to exempt. Fixes: cockroachdb#130182 Release note: None
|
This change is |
msbutler
approved these changes
Sep 5, 2024
|
@msbutler TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
130183: rpc,tenantcapabilities: allow cross tenant reads in shared service r=fqazi a=fqazi Previously, we added support for cross tenant reads, but these would only function from the system tenant. When running as a shared service tenant, we should also allow reading the spans of other tenants. To address this, this patch updates authorization logic to look at the authorization mode to determine if the cross tenant read check should be enforced, which will allow shared service tenants to exempt. Fixes: #130182 Release note: None Co-authored-by: Faizan Qazi <[email protected]>
|
bors crashed yesterday. re-trying: bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
130184: catalog: add support for replicating catalogs for reader virtual clusters r=fqazi a=fqazi This patch adds logic for extracting and creating a PCR reader catalog. This patch will do the following: 1. Introduce a new catalog function catalog.SetupOrAdvanceStandbyReaderCatalog which can be used to advanced or setup a reader catalog from a source tenant. 2. Add logic to allow read only sequence access, so that SQL behaves correctly Fixes: #129439 Note: The first commit in this PR can be ignored, and will be merged via a separate PR #130183 Co-authored-by: Faizan Qazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we added support for cross tenant reads, but these would only function from the system tenant. When running as a shared service tenant, we should also allow reading the spans of other tenants. To address this, this patch updates authorization logic to look at the authorization mode to determine if the cross tenant read check should be enforced, which will allow shared service tenants to exempt.
Fixes: #130182
Release note: None