-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rac2: add AdmittedTracker interface for use by RangeController #130054
Conversation
39902be
to
9f81f6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @kvoli and @pav-kv)
pkg/kv/kvserver/kvflowcontrol/rac2/range_controller_test.go
line 122 at r1 (raw file):
Previously, pav-kv (Pavel Kalinnikov) wrote…
What happens with the priorities !=
pri
whenTerm
goes up? Should we rather pass the wholeAdmittedVector
in and update it wholesale?
This was probably just a quick convenience in order to be able to provide just an incremental update in the test. I have added a TODO to improve this.
TFTR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @pav-kv)
pkg/kv/kvserver/kvflowcontrol/rac2/range_controller_test.go
line 122 at r1 (raw file):
Previously, sumeerbhola wrote…
This was probably just a quick convenience in order to be able to provide just an incremental update in the test. I have added a TODO to improve this.
It was convenience. We can change it.
The AdmittedTracker provides the latest AdmittedVector, and will be implemented by processorImpl. Informs cockroachdb#129508 Epic: CRDB-37515 Release note: None
9f81f6f
to
4cab332
Compare
bors r=pav-kv,kvoli |
The AdmittedTracker provides the latest AdmittedVector, and will be implemented by processorImpl.
Informs #129508
Epic: CRDB-37515
Release note: None