Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2.1-rc: roachtest: disable shared-process for follower-reads test #129604

Merged
merged 1 commit into from
Aug 25, 2024
Merged

release-24.2.1-rc: roachtest: disable shared-process for follower-reads test #129604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/cmd/roachtest/tests/follower_reads.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,10 @@ func runFollowerReadsMixedVersionSingleRegionTest(
ctx context.Context, t test.Test, c cluster.Cluster,
) {
topology := topologySpec{multiRegion: false}
runFollowerReadsMixedVersionTest(ctx, t, c, topology, exactStaleness)
runFollowerReadsMixedVersionTest(ctx, t, c, topology, exactStaleness,
// Test currently fails in shared-process deployments, see: #129167.
mixedversion.EnabledDeploymentModes(mixedversion.SystemOnlyDeployment),
)
}

// runFollowerReadsMixedVersionGlobalTableTest runs a multi-region follower-read
Expand All @@ -995,6 +998,8 @@ func runFollowerReadsMixedVersionGlobalTableTest(
survival: region,
}
runFollowerReadsMixedVersionTest(ctx, t, c, topology, strong,
// Test currently fails in shared-process deployments, see: #129167.
mixedversion.EnabledDeploymentModes(mixedversion.SystemOnlyDeployment),
// Disable fixtures because we're using a 6-node, multi-region cluster.
mixedversion.NeverUseFixtures,
// Use a longer upgrade timeout to give the migrations enough time to finish
Expand Down