-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: ui: use versioned crdb-protobuf-client #129352
release-23.2: ui: use versioned crdb-protobuf-client #129352
Conversation
Previously `cluster-ui` was using a workspace link to the protobuf client that linked directly to the `src/js` directory in the `db- console` workspace that contained this library. This made it difficult to import `cluster-ui` elsewhere as it wouldn't be able to find that dependency outside this project structure. We've separately published a 24.2.1 version of the protobuf library which will enable it to be used outside of this repo. Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you foresee any issues with the client 24.2 being set to a specific version of the protobufs? I imagine it would only be an issue for backports, but I'm not super familiar with how many backports impact protos.
@laurenbarker I think CRDB builds should be fine because typically the protos don't change in backports, and even if they did, the lockfile still references the local version (specifier has changed, but not the version), not the published file so the only drift would be if published a new version of |
Previously
cluster-ui
was using a workspace link to the protobuf client that linked directly to thesrc/js
directory in thedb- console
workspace that contained this library.This made it difficult to import
cluster-ui
elsewhere as it wouldn't be able to find that dependency outside this project structure.We've separately published a 24.2.1 version of the protobuf library which will enable it to be used outside of this repo.
Release note: None
Release justification: non-user-facing change to support
cluster-ui
lib