Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: fix comment on QueryTxnResponse.QueriedTxn #129333

Merged

Conversation

nvanbenschoten
Copy link
Member

This commit fixes a comment in the QueryTxnResponse.QueriedTxn field. It also addresses a related TODO.

Epic: None
Release note: None

This commit fixes a comment in the QueryTxnResponse.QueriedTxn field.
It also addresses a related TODO.

Epic: None
Release note: None
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner August 20, 2024 15:41
Copy link

blathers-crl bot commented Aug 20, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)


pkg/kv/kvserver/txnwait/queue.go line 1010 at r1 (raw file):

	// ID can be nil if no HeartbeatTxn has been sent yet and we're talking to a
	// 2.1 node.
	// TODO(nvanbenschoten): Remove this in 2.3.

About time! 😂

@nvanbenschoten
Copy link
Member Author

TFTR!

bors r+

@craig craig bot merged commit 333e528 into cockroachdb:master Aug 20, 2024
22 of 23 checks passed
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/queryTxnComment branch August 26, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants