kvserver/rangefeed: move perRangeEventSink to rangefeed pacakge #129227
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
I'm not entirely certain whether this movement is correct (it does feel like a node level concept). I made it so that we can do testing like this https://github.com/cockroachdb/cockroach/blob/ec95623917c6043e357a9c4ab288a1e21f516542/pkg/kv/kvserver/rangefeed/unbuffered_registration_test.go#L63-L65 with StreamMuxer in future commits. Alternatively, we can also just introduce a separate testing struct in the rangefeed package that replicates perRangeEventSink. Wdyt?
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
Previously, we introduced a registration interface to abstract the implementation details of buffered and unbuffered registration. This patch updates the p.Register function to use this interface as well. Part of: cockroachdb#126560 Release note: none
Previously, perRangeEventSink was defined in pkg/server/node.go. This patch relocates it to the rangefeed package to facilitate future commits testing within the rangefeed package itself. Part of: cockroachdb#126560 Release note: none
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 4 of 4 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status:
|
TFTR! bors r=nvanbenschoten |
kvserver/rangefeed: change p.Register to use registration interface
Previously, we introduced a registration interface to abstract the
implementation details of buffered and unbuffered registration. This patch
updates the p.Register function to use this interface as well.
Part of: #126560
Release note: none
kvserver/rangefeed: move perRangeEventSink to rangefeed pacakge
Previously, perRangeEventSink was defined in pkg/server/node.go. This patch
relocates it to the rangefeed package to facilitate future commits testing
within the rangefeed package itself.
Part of: #126560
Release note: none