ui: remove unnecessary metric name prefixes #129149
Conversation
dhartunian
added
backport-23.2.x
|
This change is |
|
Some before/after screenshots. Old view is on the left. New one is on the right. 
|
There was a problem hiding this comment.
Looks great! Thanks for doing this! Just a minor comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @dhartunian and @kyle-a-wong)
pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/overload.tsx line 205 at r1 (raw file):
name="cr.node.admission.wait_durations.elastic-stores-p99" title={ "Elastic (Background)" +
We could make do without the (Background), since we have used elastic several times on this page now.
Metrics keyed by nodeID and prefixed with long strings become very difficult to read on the dashboard pages since they take up too much horizontal space. In all of these cases, the context provided by the graph title and Y axis label provide enough context to omit verbose legend labels. Resolves: cockroachdb#128046 Release note (ui change): some metric charts on the overview and replication pages have more terse legends to facilitate easier browsing.
dhartunian
force-pushed
the
remove-unnecessary-metric-prefixes
branch
from
84f6a4f to
1c75c25
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/overload.tsx line 205 at r1 (raw file):
Previously, aadityasondhi (Aaditya Sondhi) wrote…
We could make do without the
(Background), since we have used elastic several times on this page now.
Done.
|
TFTR! bors r=aadityasondhi |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #128046: branch-release-23.2, branch-release-24.1, branch-release-24.2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 1c75c25 to blathers/backport-release-23.2-129149: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Metrics keyed by nodeID and prefixed with long strings become very difficult to read on the dashboard pages since they take up too much horizontal space. In all of these cases, the context provided by the graph title and Y axis label provide enough context to omit verbose legend labels.
Resolves: #128046
Release note (ui change): some metric charts on the overview and replication pages have more terse legends to facilitate easier browsing.