release-24.2: kvnemesis: properly skip validation for rolled-back locking reads in weak-isolation transactions #129062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #128847 on behalf of @miraradeva.
/cc @cockroachdb/release
Previously, #126417 attempted to skip validation for rolled-back locking reads that tolerate write skew. However, it depended on the validator's
observeLocking
filter incheckAtomicCommitted
to detect if a read tolerates write skew. However, that filter is set correctly only while processing ops.This patch adds a field to
observedRead
to mark it as tolerating write skew. The flag is set inprocessOp
and used later incheckAtomicCommitted
.Fixes: #128373
Release note: None
Release justification: Testing only.