raft: respect leader fortification in MsgForgetLeader #129000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs typically don't have punctuation. Epic: None Release note: None
Makes the no-op case more observable. Epic: None Release note: None
Fixes cockroachdb#124496. This commit makes peers consult leader fortification state when processing a MsgForgetLeader message. If the leader is fortified and currently supported, the peer will ignore the message. Epic: None Release note: None
|
This change is |
arulajmani
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/raft/raft.go line 1000 at r3 (raw file):
// TODO(arul): we will eventually want some kind of logic like this. // //if r.supportingFortifiedLeader() && t != campaignTransfer {
This is exactly the thing I was just messaging you about!
|
TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124496.
This commit makes peers consult leader fortification state when processing a
MsgForgetLeadermessage. If the leader is fortified and currently supported, the peer will ignore the message.Epic: None
Release note: None