Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod: azure destroy cluster returns error if no resource group was found #128969

Merged
merged 1 commit into from
Aug 14, 2024
Merged

roachprod: azure destroy cluster returns error if no resource group was found #128969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/roachprod/vm/azure/azure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,13 @@ func (p *Provider) DeleteCluster(l *logger.Logger, name string) error {
}
}

if len(futures) == 0 {
// We have seen occurrences of Azure resource groups losing the necessary tags
// needed for roachprod to find them. The cluster may need to be manually deleted
// through the Azure portal.
return errors.Newf("**** MANUAL INTERVENTION REQUIRED ****\nDeleteCluster: Found no azure resource groups with tag cluster: %s", name)
}

if !p.SyncDelete {
return nil
}
Expand Down
Loading