sql: fix TestRandomSyntaxSchemaChangeDatabase flake #128939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, TestRandomSyntaxSchemaChangeDatabase could flake because of contention from multiple Go routines executing SQL against the same database. Some of these schema changes were long-running, making this test unreliable. To address this, this patch creates multiple databases, so that every two connections will share the same database. Fixes: cockroachdb#128287 Release note: None
|
This change is |
fqazi
added
backport-23.2.x
rafiss
approved these changes
Aug 14, 2024
|
@rafiss TFTR! bors r+ |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #128287: branch-release-23.2, branch-release-24.1, branch-release-24.2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TestRandomSyntaxSchemaChangeDatabase could flake because of contention from multiple Go routines executing SQL against the same database. Some of these schema changes were long-running, making this test unreliable. To address this, this patch creates multiple databases, so that every two connections will share the same database.
Fixes: #128287
Release note: None