Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: allow VIEWACTIVITY users access to /_admin/v1/stmtbundle #128938

Merged
merged 1 commit into from
Aug 22, 2024
Merged

server: allow VIEWACTIVITY users access to /_admin/v1/stmtbundle #128938

merged 1 commit into from
Aug 22, 2024
+53 −30

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Aug 13, 2024

This commit gives users with the VIEWACTIVITY system grant access to /_admin/v1/stmtbundle on the admin server. This allows these users to download stmt bundles via DB console.

Epic: none
Part of: #121301

Release note (ui change): Users with VIEWACTIVITY can download stmt bundles from DB console.

@xinhaoz xinhaoz requested review from a team as code owners August 13, 2024 22:58
@xinhaoz xinhaoz requested review from angles-n-daemons and removed request for a team August 13, 2024 22:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@xinhaoz xinhaoz changed the title server: allow VIEWACTIVITY users acess to /_admin/v1/stmtbundle server: allow VIEWACTIVITY users access to /_admin/v1/stmtbundle Aug 13, 2024
@xinhaoz xinhaoz force-pushed the download-bundles-view-activity branch 2 times, most recently from b24ea97 to 43a9e4d Compare August 14, 2024 18:18
@xinhaoz xinhaoz requested a review from a team August 15, 2024 15:35
dhartunian
dhartunian approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @angles-n-daemons)

@xinhaoz
server: allow VIEWACTIVITY users access to /_admin/v1/stmtbundle
1c81dc3 
This commit gives users with the VIEWACTIVITY system grant
access to `/_admin/v1/stmtbundle` on the admin server. This
allows these users to download stmt bundles via DB console.

Epic: none
Part of: cockroachdb#121301

Release note (ui change): Users with VIEWACTIVITY can
download stmt bundles from DB console.
@xinhaoz xinhaoz force-pushed the download-bundles-view-activity branch from 43a9e4d to 1c81dc3 Compare August 22, 2024 15:48
@xinhaoz
Copy link
Member Author

xinhaoz commented Aug 22, 2024

TFTR!!
bors r+

@xinhaoz xinhaoz added backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 labels Aug 22, 2024
@craig
Copy link
Contributor

craig bot commented Aug 22, 2024

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 22, 2024

Build succeeded:

@craig craig bot merged commit 4625d8b into cockroachdb:master Aug 22, 2024
22 of 23 checks passed
This was referenced Aug 22, 2024
Merged
Merged
Merged
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Aug 22, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error setting reviewers, but backport branch blathers/backport-release-23.2-128938 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/129502/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.2.x failed. See errors above.

error setting reviewers, but backport branch blathers/backport-release-24.1-128938 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/129503/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 24.1.x failed. See errors above.

error setting reviewers, but backport branch blathers/backport-release-24.2-128938 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/129504/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 24.2.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@xinhaoz xinhaoz deleted the download-bundles-view-activity branch September 20, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhartunian dhartunian dhartunian approved these changes

@angles-n-daemons angles-n-daemons Awaiting requested review from angles-n-daemons angles-n-daemons is a code owner automatically assigned from cockroachdb/obs-prs

Assignees
No one assigned
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinhaoz @cockroach-teamcity @dhartunian