Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: attempt to deflake distribution strategy unit tests #128857

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

andyyang890
Copy link
Collaborator

This patch attempts to deflake the changefeed distribution strategy
unit tests by replacing all the manually constructed
ALTER TABLE ... RELOCATE statements with a single statement that
uses a select query.

Informs #125170
Informs #125231
Informs #127027
Informs #127313

Release note: None

This patch attempts to deflake the changefeed distribution strategy
unit tests by replacing all the manually constructed
`ALTER TABLE ... RELOCATE` statements with a single statement that
uses a select query.

Release note: None
@andyyang890 andyyang890 requested review from rharding6373 and a team August 12, 2024 21:16
@andyyang890 andyyang890 requested a review from a team as a code owner August 12, 2024 21:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@andyyang890
Copy link
Collaborator Author

TFTR!

bors r=rharding6373

@craig craig bot merged commit a8b016c into cockroachdb:master Aug 13, 2024
22 of 23 checks passed
@andyyang890 andyyang890 deleted the dist_test_relocate branch August 13, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants