Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: storage: fix cases of unencoded key ranges #128818

Merged

Conversation

RaduBerinde
Copy link
Member

Backport 1/1 commits from #128816.

/cc @cockroachdb/release


This is a backport of the fixes inside #128043. These are a few cases where we are passing unencoded key ranges to Pebble for various operations. This can result in an effective range that starts and/or ends sooner than intended (part of the key will be treated as the suffix).

Release justification: fix for Online Restore download phase and for key range table metrics.

Epic: none
Release note: None

This is a backport of the fixes inside cockroachdb#128043. These are a few cases
where we are passing unencoded key ranges to Pebble for various
operations. This can result in an effective range that starts and/or
ends sooner than intended (part of the key will be treated as the
suffix).

Release justification: fix for for key range table metrics.

Epic: none
Release note: None
@RaduBerinde RaduBerinde requested a review from jbowens August 12, 2024 16:52
@RaduBerinde RaduBerinde requested a review from a team as a code owner August 12, 2024 16:52
Copy link

blathers-crl bot commented Aug 12, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Aug 12, 2024
Copy link

blathers-crl bot commented Aug 12, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde merged commit 9e7ed1f into cockroachdb:release-23.2 Aug 15, 2024
5 of 6 checks passed
@RaduBerinde RaduBerinde deleted the backport23.2-128816 branch August 15, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants