sql: add dropped column to crdb_internal.table_spans.
#128788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
shubhamdhama
force-pushed
the
table_spans-include-deleted-97942
branch
from
572d951 to
37a8715
Compare
rafiss
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
nice work!
Reviewable status:
complete! 0 of 0 LGTMs obtained
This addition is useful for listing table spans that are deleted but not yet garbage collected. Informs: cockroachdb#128578, cockroachdb#128755 Epic: CRDB-12100 Release note (sql change): This adds a new column to `crdb_internal.table_spans` to indicate whether a table is dropped. Rows for dropped tables will be removed once they are garbage collected.
shubhamdhama
force-pushed
the
table_spans-include-deleted-97942
branch
from
37a8715 to
680ef6d
Compare
shubhamdhama
commented
Aug 30, 2024
|
TFTR! bors r=rafiss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is useful for listing table spans that are deleted but not yet garbage collected.
Informs: #128578, #128755, #97942
Epic: CRDB-12100
Release note (sql change): This adds a new column to
crdb_internal.table_spansto indicate whether a table is dropped. Rows for dropped tables will be removed once they are garbage collected.