release-24.2: sql: SHOW CLUSTER SETTING FOR TENANT returns NULL for renamed cluster setting #128784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #128675 on behalf of @stevendanna.
/cc @cockroachdb/release
If a cluster setting has been renamed, the internal key used in the settings tables is different from the name. The lookup code was using the user-facing Name rather than the InternalKey, resulting in SHOW CLUSTER SETTING FOR TENANT returning NULL for settings that had been renamed.
Epic: none
Release note (bug fix): Fix a bug in which SHOW CLUSTER SETTING FOR VIRTUAL CLUSTER would erroneously return NULL for some settings.
Release justification: low risk bug fix