kvserverpb: add RaftMessageRequest.UsingRAC2Protocol #128754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Informs cockroachdb#128309 Epic: CRDB-37515 Release note: None
|
This change is |
sumeerbhola
commented
Aug 10, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @kvoli and @pav-kv)
pkg/kv/kvserver/kvserverpb/raft.proto line 101 at r1 (raw file):
// UsingRAC2Protocol is set to true iff the leader is using the RACv2 // protocol. bool using_rac2_protocol = 12;
I forgot about the need for this field in the previous PR. The UsingRAC2Protocol belongs "before" the other field, and since the other field has never been used, I've switched the tag numbers too.
kvoli
approved these changes
Aug 12, 2024
|
TFTR! |
|
bors r=kvoli |
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #128309
Epic: CRDB-37515
Release note: None