Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: changefeedccl: make the kafka v2 and pubsub sinks display topic notices #128333

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 5, 2024

Backport 1/1 commits from #128117 on behalf of @asg0451.

/cc @cockroachdb/release


Some sinks have the ability to display a notice to
the user indicating which topics will be created,
such as kafka v1. This adds the ability for kafka
v2 to do so as well.

Epic: None

Release note (enterprise change): The kafka v2 sink
now displays notices indicating the topics it will
emit to.


Release justification: maintain parity with the v1 sink which we are backporting as well

Some sinks have the ability to display a notice to
the user indicating which topics will be created,
such as kafka v1. This adds the ability for kafka
v2 and pubsub to do so as well.

Epic: None

Release note (enterprise change): The kafka v2 and
pubsub sinks now displays notices indicating the
topics it will emit to.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-128117 branch from 472c970 to 01b2045 Compare August 5, 2024 20:43
@blathers-crl blathers-crl bot requested a review from a team as a code owner August 5, 2024 20:43
@blathers-crl blathers-crl bot requested review from andyyang890 and removed request for a team August 5, 2024 20:43
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 5, 2024
Copy link
Author

blathers-crl bot commented Aug 5, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from rharding6373 August 5, 2024 20:43
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Aug 5, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@asg0451 asg0451 merged commit c05674b into release-24.1 Aug 6, 2024
19 of 20 checks passed
@asg0451 asg0451 deleted the blathers/backport-release-24.1-128117 branch August 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants