Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: refactor prompts for autofix permission #128211

Merged
merged 2 commits into from
Aug 2, 2024

Commits on Aug 2, 2024

  1. dev: in doctor, add --sandbox_add_mount_pair if relevant

    This was apparently broken with the Bazel 7 upgrade and
    bazelbuild/bazel#22001 specifically. If `--test_tmpdir` is set to
    some directory under `/tmp`, we need to add `/tmp` as a mount pair as
    well. This cannot be done in remote mode so `doctor` needs to be aware
    of this.
    
    Closes: cockroachdb#128204
    Epic: None
    Release note: None
    Release justification: Build-only code changes
    rickystewart committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3574e83 View commit details
    Browse the repository at this point in the history
  2. dev: refactor prompts for autofix permission

    This code is duplicated in many places, so this refactor saves us some
    LOC.
    
    Epic: none
    Release note: None
    Release justification: Build-only code changes
    rickystewart committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    762446f View commit details
    Browse the repository at this point in the history