-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add telemetry counters for generic query plans #127897
Conversation
Fixes cockroachdb#127651 Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @kyle-a-wong and @mgartner)
pkg/sql/plan_opt.go
line 573 at r1 (raw file):
switch opc.p.SessionData().PlanCacheMode { case sessiondatapb.PlanCacheModeForceCustom: telemetry.Inc(sqltelemetry.PlanTypeForceCustomCounter)
Do you think there could be any impact on performance potentially doing this for every query? Would it be worth doing only on a sampling basis or something?
Previously, DrewKimball (Drew Kimball) wrote…
I was worried about that, but we have other counters that are incremented for every query, so I thought this would be no different: cockroach/pkg/sql/opt/exec/execbuilder/relational.go Lines 2551 to 2552 in 2c32e20
|
TFTR! bors r+ |
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #127651: branch-release-23.2, branch-release-24.1. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 7e10c1a to blathers/backport-release-23.2-127897: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.x failed. See errors above. error creating merge commit from 7e10c1a to blathers/backport-release-24.1-127897: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fixes #127651
Release note: None