Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: include MaxTimestampAge info for TableReader in DistSQL diagrams #127583

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

yuzefovich
Copy link
Member

This commit includes MaxTimestampAge field of the TableReaderSpec into the DistSQL diagram. This feature is used by the table stats collection to utilize the inconsistent scan, and it'll be easier to confirm that it's actually used under the hood.

Informs: #72719.
Epic: None

Release note: None

This commit includes `MaxTimestampAge` field of the `TableReaderSpec`
into the DistSQL diagram. This feature is used by the table stats
collection to utilize the inconsistent scan, and it'll be easier to
confirm that it's actually used under the hood.

Release note: None
@yuzefovich yuzefovich requested review from Uzair5162 and michae2 July 20, 2024 20:29
@yuzefovich yuzefovich requested a review from a team as a code owner July 20, 2024 20:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @Uzair5162)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig craig bot merged commit 59bb8eb into cockroachdb:master Jul 26, 2024
22 checks passed
@yuzefovich yuzefovich deleted the stats-diagram branch July 26, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants