Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: add log messages for when a core changefeed retries/fails #127530

Merged
merged 1 commit into from
Jul 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/ccl/changefeedccl/changefeed_stmt.go
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,14 @@ func coreChangefeed(
err = knobs.HandleDistChangefeedError(err)
}

if err = changefeedbase.AsTerminalError(ctx, p.ExecCfg().LeaseManager, err); err != nil {
if err := changefeedbase.AsTerminalError(ctx, p.ExecCfg().LeaseManager, err); err != nil {
log.Infof(ctx, "core changefeed failed due to error: %s", err)
return err
}

// All other errors retry; but we'll use an up-to-date progress
// information which is saved in the localState.
log.Infof(ctx, "core changefeed retrying due to transient error: %s", err)
}
return ctx.Err() // retry loop exits when context cancels.
}
Expand Down
Loading