crosscluster/logical: add mode option parsing #127384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Jeremyyang920
requested review from
dt and
stevendanna
and removed request for
a team
Jeremyyang920
force-pushed
the
jyang/mode
branch
from
9f6f05f to
b0517b3
Compare
|
Only the last commit is relevant. I rebased #127428 to get the proto updates. |
This commit allows for the parsing of the mode option. Since we only support a single mode right now, when not provided it is set by default. Any other options other than immediate will result in an error Epic: none Release note: None
Jeremyyang920
force-pushed
the
jyang/mode
branch
from
b0517b3 to
05f085a
Compare
|
I think we added this along the way in another PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows for the parsing of the mode option. Since we only support a single mode right now, when not provided it is set by default. Any other options other than immediate will result in an error.
Tests are also added to ensure error handling of options is properly returned.
Epic: none
Release note: None