Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schematelemetry: test that logs are redacted correctly #127381

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jul 17, 2024

follow-up from #127195
informs: #126584
Release note: None

@rafiss rafiss requested a review from annrpom July 17, 2024 19:11
@rafiss rafiss requested a review from a team as a code owner July 17, 2024 19:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@annrpom annrpom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

pkg/sql/catalog/schematelemetry/schema_telemetry_test.go Outdated Show resolved Hide resolved
pkg/sql/catalog/schematelemetry/schema_telemetry_test.go Outdated Show resolved Hide resolved
@rafiss rafiss force-pushed the log-redaction-test branch from acf2124 to e42017d Compare July 17, 2024 20:39
@rafiss
Copy link
Collaborator Author

rafiss commented Jul 17, 2024

tftr!

bors r+

@craig craig bot merged commit 13d71ca into cockroachdb:master Jul 17, 2024
21 of 22 checks passed
@rafiss rafiss deleted the log-redaction-test branch July 18, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants