Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: require an enterprise license to use generic query plans #127214

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Jul 16, 2024

Epic: CRDB-37712

Release note: None

@mgartner mgartner requested a review from a team July 16, 2024 00:29
@mgartner mgartner requested review from a team as code owners July 16, 2024 00:29
@mgartner mgartner requested review from rytaft and removed request for a team July 16, 2024 00:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner added backport-24.2.x Flags PRs that need to be backported to 24.2 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. labels Jul 16, 2024
@mgartner mgartner requested a review from yuzefovich July 16, 2024 00:30
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

nit: it might be nice to mark gqpccl package as owned by SQL Queries team in CODEOWNERS.

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)

@mgartner mgartner requested a review from a team as a code owner July 16, 2024 15:16
Copy link
Collaborator Author

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it might be nice to mark gqpccl package as owned by SQL Queries team in CODEOWNERS.

Good catch. Looks like the linter requires it. 👍

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 16 of 16 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @mgartner)

@mgartner
Copy link
Collaborator Author

TFTRs!

bors r+

@craig craig bot merged commit 2a1a03d into cockroachdb:master Jul 16, 2024
22 checks passed
Copy link

blathers-crl bot commented Jul 16, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from ba8e131 to blathers/backport-release-23.2-127214: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


error creating merge commit from ba8e131 to blathers/backport-release-24.1-127214: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1.x failed. See errors above.


error creating merge commit from ba8e131 to blathers/backport-release-24.2-127214: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants