Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: fix query fetching store ids for db/tables #127090

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Jul 12, 2024

Backport:

cc @cockroachdb/release


These queries were updated in #118904 to make them more performant. In that change we mistakenly removed the null check before reading the rows field, causing pages using this request to crash if this query fails.

Epic: none
Fixes: #126348

Release note (bug fix): Database overview and db details pages should not crash if the range information is not available.

Release justification: bug fix

@xinhaoz xinhaoz requested a review from a team as a code owner July 12, 2024 20:57
@xinhaoz xinhaoz requested review from kyle-a-wong and removed request for a team July 12, 2024 20:57
Copy link

blathers-crl bot commented Jul 12, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jul 12, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@xinhaoz xinhaoz requested review from dhartunian and rafiss July 12, 2024 21:07
These queries were updated in cockroachdb#118904 to make them more performant.
In that change we mistakenly removed the null check before reading
the `rows` field, causing pages using this request to crash if this
query fails.

Epic: none
Fixes: cockroachdb#126348

Release note (bug fix): Database overview and db details
pages should not crash if the range information is not
available.
@xinhaoz xinhaoz force-pushed the backport23.1-126419 branch from 146e655 to 36e7f8d Compare July 16, 2024 14:31
@xinhaoz xinhaoz merged commit e84d1de into cockroachdb:release-23.1 Jul 16, 2024
6 checks passed
@xinhaoz xinhaoz deleted the backport23.1-126419 branch July 16, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants