jwtauthccl: use RedactableString for detailed error

[rafiss]

Also, only join the detailed error string if it's non-empty.

Epic: None
Release note: None

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[souravcrl]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

---

pkg/ccl/jwtauthccl/authentication_jwt.go line 189 at r1 (raw file):

		jwkSet, err = authenticator.remoteFetchJWKS(ctx, issuerUrl)
		if err != nil {
			return redact.Sprintf("unable to fetch jwks: %v", err),

I found we can't redact this err targetedly. link: https://reviewable.io/reviews/cockroachdb/cockroach/126227#-O1I-UnF7W0DluMm7qoz

---

pkg/sql/pgwire/auth_methods.go line 786 at r1 (raw file):

		if detailedErrors, authError := jwtVerifier.ValidateJWTLogin(ctx, execCfg.Settings, user, []byte(token), identMap); authError != nil {
			errForLog := authError
			if detailedErrors != "" {

took note of this and updated my implementation https://reviewable.io/reviews/cockroachdb/cockroach/126227

[rafiss]

thanks for the review!

bors r+

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @souravcrl)

---

pkg/ccl/jwtauthccl/authentication_jwt.go line 189 at r1 (raw file):

Previously, souravcrl wrote…

I found we can't redact this err targetedly. link: https://reviewable.io/reviews/cockroachdb/cockroach/126227#-O1I-UnF7W0DluMm7qoz

that's correct, we cannot retroactively apply selective redaction to an error after it's constructed. it's up to the creator of the error to do that, or to define a SafeFormatError function for that error type.

so for errors from 3rd party libraries, the entire error text will get redacted in logs.

[craig]

Build failed (retrying...):

• unit_tests

[craig]

Build succeeded:

• acceptance
• local_roachtest
• local_roachtest_fips
• linux_arm64_build
• examples_orms
• macos_amd64_build
• windows_build
• lint
• linux_amd64_build
• docker_image_amd64
• unit_tests
• linux_amd64_fips_build
• check_generated_code
• macos_arm64_build