release-23.1: workload/schemachange: handle desc ID generator errors #126905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, during migrations to version 23.1, if a descriptor ID generator error occurred during CREATE SCHEMA, the process would incorrectly fail in this test. This error is expected due to the addition of a new sequence for tracking descriptor IDs in version 23.1. To resolve this, this patch introduces logic to detect and ignore this error specifically for CREATE SCHEMA operations. Fixes: cockroachdb#126784 Release note: None
fqazi
requested review from
herkolategan and
renatolabs
and removed request for
a team
|
This change is |
fqazi
changed the title
rafiss
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @herkolategan and @renatolabs)
|
blathers backport release-23.1.24-rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, during migrations to version 23.1, if a descriptor ID generator error occurred during CREATE SCHEMA, the process would incorrectly fail in this test. This error is expected due to the addition of a new sequence for tracking descriptor IDs in version 23.1. To resolve this, this patch introduces logic to detect and ignore this error specifically for CREATE SCHEMA operations.
Fixes: #126784
Release justification: test only change
Release note: None