Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: fix TestTenantStatusAPI test #126498

Merged

Conversation

dhartunian
Copy link
Collaborator

Previously, this test would use a single connection, cancel it, and then use the connection to verify the cancellation.

The test is adjusted here to use two separate sessions, one to cancel for testing, and another to observe the cancellation.

Resolves: #125404
Epic: None

Release note: None

@dhartunian dhartunian requested a review from xinhaoz July 1, 2024 15:22
@dhartunian dhartunian requested a review from a team as a code owner July 1, 2024 15:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, this test would use a single connection, cancel it, and
then use the connection to verify the cancellation.

The test is adjusted here to use two separate sessions, one to cancel
for testing, and another to observe the cancellation.

Resolves: cockroachdb#125404
Epic: None

Release note: None
@dhartunian dhartunian force-pushed the fix-tenant-status-test-cancel-session branch from 1c445ce to 7d4d517 Compare July 1, 2024 21:11
@dhartunian
Copy link
Collaborator Author

bors r=xinhaoz

@craig craig bot merged commit 786cb46 into cockroachdb:master Jul 2, 2024
22 checks passed
@dhartunian dhartunian deleted the fix-tenant-status-test-cancel-session branch July 2, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/ccl/serverccl/statusccl/statusccl_test: TestTenantStatusAPI failed
3 participants