Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl,keys,sql,storage,util: restructure fuzz tests #125905

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Nukitt
Copy link
Contributor

@Nukitt Nukitt commented Jun 19, 2024

Previously we've had the fuzz tests and unit tests in the same _test.go file. This has to be changed now since oss-fuzz uses this to compile fuzzers which has a limitation that

_test.go files are currently not included in the scope of the build.

To address this we have separate our fuzz tests and unit tests, putting the fuzz tests in X_fuzz.go files.

Epic: None
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

blathers-crl bot commented Jun 24, 2024

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@srosenberg srosenberg marked this pull request as ready for review July 2, 2024 04:09
@srosenberg srosenberg requested review from a team as code owners July 2, 2024 04:09
@srosenberg srosenberg requested a review from sumeerbhola July 2, 2024 04:09
Copy link
Member

@srosenberg srosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo commit msg. and some linter issues.

@Nukitt Nukitt changed the title oss-fuzz: restructure existing fuzz tests ccl,keys,sql,storage,util: restructure fuzz tests Jul 2, 2024
@Nukitt
Copy link
Contributor Author

Nukitt commented Jul 2, 2024

TFTR!

bors r=srosenberg

@craig craig bot merged commit 37fd8f1 into cockroachdb:master Jul 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants