opt: add generic query plan tests with partial indexes #125871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
The first two comments are from #125795. |
DrewKimball
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 5 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2)
mgartner
force-pushed
the
generic-partial-index
branch
from
120de4d to
31ad411
Compare
michae2
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Might also be interesting to see a case something like:
CREATE INDEX partial_idx ON t(k, i) WHERE i = k;
SELECT * FROM t WHERE k = $1 AND i = $1Reviewed all commit messages.
Reviewable status:
Tests for generic query plans with partial indexes have been added. No code changes are needed in order for a query with a filter like `col = $1` to utilize an index on `(col) WHERE col IS NOT NULL`. Release note: None
mgartner
force-pushed
the
generic-partial-index
branch
from
31ad411 to
349ec26
Compare
mgartner
commented
Jun 24, 2024
There was a problem hiding this comment.
I added a test like that. It seems to work well.
TFTRs!
bors r+
Reviewable status:
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for generic query plans with partial indexes have been added. No
code changes are needed in order for a query with a filter like
col = $1to utilize an index on(col) WHERE col IS NOT NULL.Epic: CRDB-37712
Release note: None