Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush MVCC stats to range and store counters. #125

Merged
merged 2 commits into from
Oct 14, 2014

Conversation

spencerkimball
Copy link
Member

On successful execution of a range read-write command, flush accumulated
mvcc stats to merging counters for range and store.

On successful execution of a range read-write command, flush accumulated
mvcc stats to merging counters for range and store.
@@ -37,6 +37,21 @@ const (
scanRowCount = int64(1 << 8)
)

// encodeMVCCStatValue constructs a proto.Value using the supplied
// stat increment and then encodes that into a byte slice. Encoding
// errors cause panice (as they should never happen). Returns false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/s/panice/panic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jiangmingyang
Copy link
Contributor

LGTM

@spencerkimball spencerkimball force-pushed the spencerkimball/stat-counters branch from d9a46b2 to df183b4 Compare October 14, 2014 15:38
spencerkimball added a commit that referenced this pull request Oct 14, 2014
Flush MVCC stats to range and store counters.
@spencerkimball spencerkimball merged commit 7a97344 into master Oct 14, 2014
@spencerkimball spencerkimball deleted the spencerkimball/stat-counters branch October 14, 2014 15:55
soniabhishek pushed a commit to soniabhishek/cockroach that referenced this pull request Feb 15, 2017
…n_changes

response parsing change string to interface
pav-kv pushed a commit to pav-kv/cockroach that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants