release-24.1: roachprod: fix update & get latest #124931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #124592.
/cc @cockroachdb/release
Previously, roachprod binary was fetched directly from
the artifacts of a corresponding TeamCity build.
After moving it to Github actions with Engflow, the
artifact is no longer mapped to a unique URL, thus
making it cumbersome to fetch via an API.
This change updates Roachtest Nightly (in TC for
the foreseeable future) to upload the roachprod binary
into GCS, where we already store other artifacts, e.g.,
(roachperf) stats.json. Consequently, we update
scripts/roachprod-get-latest.sh
androachprod update
to fetch the binary from the new location. Finally, we
add additional sanity checks around "staleness", including
a warning in roachprod (on startup), if the binary is older
than two weeks.
Note that this PR makes only linux/amd64 roachprod binaries
available. For mac and arm64 builds, we'd have to configure
CI to upload the corresponding binaries.
Informs: #120750
Epic: CRDB-8035
Release note: None
Release justification: test-only change