roachtest: minor improvements #124922
Merged
roachtest: minor improvements #124922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: None Release note: None
The roachtest runner consists of a number of workers running tests in parallel. Each worker is linked to the cluster that it is currently using. Before this patch, a cluster was only registered with the test once a test started. This was unnecessarily late; the patch moves the registration to happen earlier, closer to when the cluster is created or picked up by the worker, which better matches the intended semnatics of this link. In particular, the linking now happens before the cockroach binary is uploaded to the cluster (a potentially slow operation), whereas before it happened after. These links between workers and clusters are used by the roachtest's web UI, which will now more accurately show who's using a cluster. Epic: none Release note: None
andreimatei
requested review from
DarrylWong and
renatolabs
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
blathers-crl
bot
added
O-community
|
This change is |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
The commits were extracted from #124780.