sql: add some logging on SQL / KV boundary #124779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
michae2
approved these changes
May 29, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
This commit audits all main entry points from SQL to KV and adds simple log messages (hidden behind verbosity level 2) right before performing the KV operation. We do so both on the write and read paths. This could be helpful when investigating latency spikes with gaps in the traces (although it's still likely to be insufficient in practice - i.e. Go execution traces are likely to be needed, yet this commit could make things a bit clearer). Release note: None
|
TFTR! bors r+ |
|
Build failed: |
|
bors r+ |
|
Build failed: |
|
Another pre-emption. bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit audits all main entry points from SQL to KV and adds simple log messages (hidden behind verbosity level 2) right before performing the KV operation. We do so both on the write and read paths. This could be helpful when investigating latency spikes with gaps in the traces (although it's still likely to be insufficient in practice - i.e. Go execution traces are likely to be needed, yet this commit could make things a bit clearer).
Fixes: #112902.
Release note: None