-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: roachtest: make failure recovery independent #124608
Merged
andrewbaptist
merged 1 commit into
release-23.2
from
blathers/backport-release-23.2-119650
May 31, 2024
Merged
release-23.2: roachtest: make failure recovery independent #124608
andrewbaptist
merged 1 commit into
release-23.2
from
blathers/backport-release-23.2-119650
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the multiple failures were started and finished independently. This caused a problem if the ability to recover from one failure depended on a different failure recovering first. To mitigate this, recover each failure in a separate goroutine. This will allow the "most important" failure to recover first so that the others can recover if they depend on each other. This is more important today while we don't recover from all the failure modes that chaos implements. Specifically we don't handle partial partitions fully with epoch leases. Epic: none Fixes: #119085 Fixes: #119347 Fixes: #119361 Fixes: #119454 Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-119650
branch
from
May 23, 2024 13:28
97874db
to
e51a4c4
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
May 23, 2024
blathers-crl
bot
requested review from
nameisbhaskar and
renatolabs
and removed request for
a team
May 23, 2024 13:28
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
requested review from
andrewbaptist,
DarrylWong and
nvanbenschoten
May 23, 2024 13:28
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
May 23, 2024
nvanbenschoten
approved these changes
May 31, 2024
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #119650 on behalf of @andrewbaptist.
/cc @cockroachdb/release
Previously, the multiple failures were started and finished
independently. This caused a problem if the ability to recover from one
failure depended on a different failure recovering first. To mitigate
this, recover each failure in a separate goroutine. This will allow the
"most important" failure to recover first so that the others can recover
if they depend on each other.
This is more important today while we don't recover from all the failure
modes that chaos implements. Specifically we don't handle partial
partitions fully with epoch leases.
Epic: none
Fixes: #119085
Fixes: #119347
Fixes: #119361
Fixes: #119454
Release note: None
Release justification: Test only change.