roachprod: delete cluster config on GC #124604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameisbhaskar
requested review from
DarrylWong and
vidit-bhat
and removed request for
a team
|
This change is |
nameisbhaskar
force-pushed
the
user/bhaskar/delete-cc-on-gc
branch
2 times, most recently
from
c063079 to
df671c9
Compare
DarrylWong
reviewed
May 28, 2024
nameisbhaskar
force-pushed
the
user/bhaskar/delete-cc-on-gc
branch
3 times, most recently
from
bb82246 to
91074e1
Compare
nameisbhaskar
force-pushed
the
user/bhaskar/delete-cc-on-gc
branch
from
91074e1 to
a57f692
Compare
yes, I have tested this! I created a cluster with |
currently, prometheus cluster configs are not deleted on gc. This makes stale entries to remain. This PR deletes the cluster configs on GC. There is another minor fix for promhelpers access. The access to cloud storage was failing due to missing credentials. Fixes: cockroachdb#124599 Epic: none
nameisbhaskar
force-pushed
the
user/bhaskar/delete-cc-on-gc
branch
from
a57f692 to
e4cb5c1
Compare
|
Thanks @DarrylWong and @herkolategan for your comments. I have resolved all. Please do take a look! |
DarrylWong
approved these changes
May 29, 2024
herkolategan
approved these changes
May 29, 2024
|
bors r=@DarrylWong @herkolategan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, prometheus cluster configs are not deleted on gc. This makes stale entries to remain. This PR deletes the cluster configs on GC.
There is another minor fix for promhelpers access. The access to cloud storage was failing due to missing credentials.
Fixes: #124599
Epic: none