release-23.1.22-rc: release-23.1: ccl,sql,util: Fix jwt auth and add sensitive error logs #124361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #124130 on behalf of @souravcrl.
/cc @cockroachdb/release
Backport 1/1 commits from #123697.
/cc @cockroachdb/release
ccl,sql,util: Fix jwt auth and add sensitive error logs
We are running into issues with jwt authentication and currently unable to
provide support as we are not logging the error from the http client used in the
authenticator. The PR looks to propagate this obtained error from
ValidateJWTLogin
http client. The http client now also respects the systemhttp proxy if set.
Validated the error details when presenting an expired token
Validated error on setting wrong proxy params
and logged error:
Verified access logs after setting up squid proxy and passing env HTTP_PROXY and
HTTPS_PROXY params
fixes #123575, CRDB-38386, CRDB-38408
Epic None
Release note: Noneccl,sql,util: Fix jwt auth and add sensitive error logs
We are running into issues with jwt authentication and currently unable to
provide support as we are not logging the error from the http client used in the
authenticator. The PR looks to propagate this obtained error from
ValidateJWTLogin
http client. The http client now also respects the systemhttp proxy if set.
Validated the error details when presenting an expired token
Validated error on setting wrong proxy params
and logged error:
Verified access logs after setting up squid proxy and passing env HTTP_PROXY and
HTTPS_PROXY params
fixes #123575, CRDB-38386, CRDB-38408
Epic None
Release note: None
Release justification: the backport is needed to fix jwks auto fetch in http proxy env
Release justification: