roachtest: add order validation to CDC Kafka roachtests #124195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This patch eliminates unnecessary nesting in orderValidator's NoteRow method. Release note: None
andyyang890
force-pushed
the
kafka_order_validator
branch
from
f3d2d1b to
577eed7
Compare
andyyang890
requested review from
nameisbhaskar,
vidit-bhat,
rharding6373,
wenyihu6 and
a team
and removed request for
a team
andyyang890
force-pushed
the
kafka_order_validator
branch
4 times, most recently
from
f295738 to
583cb04
Compare
This patch renames `MakeCountValidator` to `NewCountValidator` to reflect that it returns a pointer, not a struct. Release note: None
This patch renames the `cdc/sink-chaos` test to `cdc/kafka-chaos` to more accurately reflect that it is a Kafka-only test. It also adds logging for the Kafka chaos loop iteration number so that we can tell when the Kafka cluster is restarting from the logs. Release note: None
andyyang890
force-pushed
the
kafka_order_validator
branch
from
971d9a3 to
f162051
Compare
This patch adds order validation to CDC Kafka roachtests so that we can build more confidence in our ordering guarantees. It can be enabled for a roachtest either by directly setting the `validateOrder` flag on a `kafkaManager` before creating consumers, or indirectly by setting the `validateOrder` flag on `kafkaFeedArgs` for tests that use `cdcTester`. Release note: None
andyyang890
force-pushed
the
kafka_order_validator
branch
2 times, most recently
from
0bd0c44 to
3428726
Compare
rharding6373
approved these changes
May 17, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 4 of 4 files at r5, 1 of 1 files at r6.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nameisbhaskar, @vidit-bhat, and @wenyihu6)
|
TFTR! bors r=rharding6373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds order validation to CDC Kafka roachtests so that we
can build more confidence in our ordering guarantees. It can be enabled
for a roachtest either by directly setting the
validateOrderflag on akafkaManagerbefore creating consumers, or indirectly by setting thevalidateOrderflag onkafkaFeedArgsfor tests that usecdcTester.Informs #124148
Release note: None