Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: move generate-fixtures roachtest to test-eng ownership #123400

Merged
merged 1 commit into from
May 1, 2024
Merged

roachtest: move generate-fixtures roachtest to test-eng ownership #123400

merged 1 commit into from
May 1, 2024

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented May 1, 2024 •
edited
Loading

Epic: none
Release note: None

@rickystewart rickystewart added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. labels May 1, 2024
@rickystewart rickystewart requested a review from RaduBerinde May 1, 2024 19:04
@rickystewart rickystewart requested a review from a team as a code owner May 1, 2024 19:04
@rickystewart rickystewart requested review from srosenberg and DarrylWong and removed request for a team May 1, 2024 19:04
@rickystewart rickystewart changed the title streamclient: allow running on remote execution roachtest: move generate-fixtures roachtest to test-eng ownership May 1, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde
Copy link
Member

Change LGTM. I'll let someone from test-eng approve.

@rickystewart
Copy link
Collaborator Author

bors r=renatolabs

@craig
Copy link
Contributor

craig bot commented May 1, 2024

Build succeeded:

@craig craig bot merged commit e7e5ea1 into cockroachdb:master May 1, 2024
22 checks passed
This was referenced May 1, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatolabs renatolabs renatolabs approved these changes

@RaduBerinde RaduBerinde Awaiting requested review from RaduBerinde

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg was automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong was automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickystewart @cockroach-teamcity @RaduBerinde @renatolabs